Select the NativeAOT runtime pack as the target package when it's provided as part of the KnownILCompilerPack metadata #46611
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided as part of the KnownILCompilerPack metadata. Depends on dotnet/runtime#111876
sbomer
approved these changes
Feb 13, 2025
Comment on lines
+850
to
+851
| // If we have a separate pack pattern for the runtime pack, | ||
| // we should always use the runtime pack (the host pack may not have the tooling we need for the target). |
There was a problem hiding this comment.
I found the mention of the host pack a little confusing since we already pull a separate target-specific package when needed. I'd change this to "If there's an available runtime pack, use it instead of the ILCompiler package for target-specific bits." or something along those lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NativeAOT targets now support using the NativeAOT runtime pack as the "runtime" ILC package.
Add support (and use by default when available) the NativeAOT runtime pack as the "target" package for NativeAOT, even when not using
UseNativeAotRuntimePack(which has some issues around publishing that are being worked on in parallel in #37872).This change will allow us to change the ILCompiler pack itself (not the runtime pack) to only have the assets for running the ILCompiler, not the runtime assets for that target.